resolving-review-comments

Files (1)

• SKILL.md

SKILL.md (first lines)

# Resolving Review Comments

After the PR author pushes commits addressing review feedback, this skill fetches recent changes, compares them against unresolved review threads, and programmatically resolves threads whose feedback has been implemented in code. For threads with author replies, it evaluates the argument and responds appropriately.

## When to Use

- User says "resolve comments", "resolve review threads", "check and resolve"
- User says "check recent commits and resolve what's been fixed"
- After pushing fixes for review feedback
- When asked to re-review and resolve addressed comments

## Prerequisites

- GitHub CLI authenticated: `gh auth status`
- In a repo with an open PR on the current branch (auto-checkout below if not)
- You are the reviewer (reviewers resolve their own comments per team guidelines)

## Workflow

### 0. Checkout PR Branch (MANDATORY)

**IMPORTANT: Do NOT use `gh api repos/.../contents` or any other remote API to read file contents. Always work from a local checkout. It is faster for multiple file reads, enables grep and broad context checks, and produces more reliable verification.**

You MUST have a local working copy of the PR branch before proceeding to any later step. Check it out:

```bash
# Extract PR info
PR_NUMBER=<N>
REPO_NAME=$(gh pr view "$PR_NUMBER" --json repository --jq '.repository.name // empty' 2>/dev/null \
  || basename "$(gh repo view --json name -q .name)")
BRANCH=$(gh pr view "$PR_NUMBER" --json headRefName -q .headRefName)
```

**Try methods in order:**

```bash
# Method 1: Already on the branch
CURRENT=$(git branch --show-current 2>/dev/null)
if [ "$CURRENT" = "$BRANCH" ]; then
  echo "Already on $BRANCH"

# Method 2: Existing worktree
elif [ -d "${WORKTREE_BASE:-$HOME/worktrees}/$REPO_NAME/$BRANCH" ]; then
  cd "${WORKTREE_BASE:-$HOME/worktrees}/$REPO_NAME/$BRANCH"

# Method 3: Cross-repo task directory
elif ls -d "${CROSS_REPO_BASE:-$HOME/cross-repo-tasks}"/*/"$REPO_NAME" 2>/dev/null | head -1 | grep -q .; then
  cd "$(ls -d "${CROSS_REPO_BASE:-$HOME/cross-repo-tasks}"/*/"$REPO_NAME" 2>/dev/null | head -1)"

# Method 4: wt-continue (branch exists on remote)
else
  wt-continue "$REPO_NAME" "$BRANCH"
  cd "${WORKTREE_BASE:-$HOME/worktrees}/$REPO_NAME/$BRANCH"
fi
```

**Safety checks before syncing:**

```bash
# Abort if uncommitted changes
if [ -n "$(git status --porcelain)" ]; then
  echo "❌ ABORT: Uncommitted changes detected. Stash or commit first."
  git status --short
  exit 1
fi

# Abort if unpushed commits
if [ -n "$(git log origin/$BRANCH..$BRANCH --oneline 2>/dev/null)" ]; then
  echo "❌ ABORT: Unpushed local commits. Push first: git push origin $BRANCH"
  exit 1
fi

# Sync with remote
git fetch origin
git reset --hard "origin/$BRANCH"
```

### 1. Identify the PR

```bash
# Get PR number for current branch
PR_NUMBER=$(gh pr view --json number -q .number)
REPO=$(gh repo view --json nameWithOwner -q .nameWithOwner)
OWNER=$(echo "$REPO" | cut -d'/' -f1)
REPO_NAME=$(echo "$REPO" | cut -d'/' -f2)
```

### 2. Fetch and Check Recent Commits

```bash
git fetch origin

# Show recent commits on the PR branch
gh pr view "$PR_NUMBER" --json commits --jq '.commits[-5:].[] | "\(.oid[:7]) \(.messageHeadline)"'

# Get the diff of recent changes to understand what was fixed
git diff HEAD~3..HEAD  # adjust range based on context
```

### 3. Fetch All Unresolved Review Threads

Use the GitHub GraphQL API to get all review threads with their comments:

```bash
gh api graphql -f query='
query($owner: String!, $repo: String!, $pr: Int!) {
  repository(owner: $owner, name: $repo) {
    pullRequest(number: $pr) {
      reviewThreads(first: 100) {
        nodes {
          id
          isResolved
          isOutdated
          path
          line
          startLine
          comments(first: 20) {
            nodes {
              id

From DrJKL/ticket-to-pr-pipeline, MIT.

More from DrJKL/ticket-to-pr-pipeline