addressing-review-comments

Files (1)

• SKILL.md

SKILL.md (first lines)

# Addressing Review Comments

Checks out a PR branch, implements each code review comment as a separate commit (with a hyperlink to the comment URL in the commit message), runs quality gates, and hands off to resolve threads and reassign the PR.

## When to Use

- User says "address review comments", "fix review feedback", "implement PR suggestions"
- User says "the PR got reviewed, go fix the comments"
- User provides a PR URL or number and asks to handle the review feedback
- After a code review round, to implement fixes and push back

## Prerequisites

- GitHub CLI authenticated: `gh auth status`
- `git-worktree-utils` installed and sourced (see `worktree-utils` skill)
- Write access to the repository

## Configuration

Uses the **production API** by default. No configuration needed for read operations.

**Defaults (no setup required):**

- API URL: `https://api-gateway-856475788601.us-central1.run.app`
- Read-only endpoints at `/public/*` require no authentication

**For write operations** (state transitions), set:

```bash
export PIPELINE_API_KEY="..."  # Get from GCP Secret Manager or ask admin
```

## Workflow

### 1. Identify the PR

```bash
# From a PR URL or number
PR_NUMBER=<N>
REPO=$(gh pr view "$PR_NUMBER" --json repository --jq '.repository.nameWithOwner // empty' 2>/dev/null \
  || gh repo view --json nameWithOwner -q .nameWithOwner)
OWNER=$(echo "$REPO" | cut -d'/' -f1)
REPO_NAME=$(echo "$REPO" | cut -d'/' -f2)
BRANCH=$(gh pr view "$PR_NUMBER" --repo "$REPO" --json headRefName -q .headRefName)
```

### 2. Checkout the Branch via Worktree

Try methods in order:

**Method 1: wt-continue (preferred — branch was created on another system)**

```bash
wt-continue "$REPO_NAME" "$BRANCH"
cd "$WORKTREE_BASE/$REPO_NAME/$BRANCH"
```

**Method 2: Navigate to existing worktree**

Check common locations:

```bash
# Standard worktree location
WORKTREE_PATH="$WORKTREE_BASE/$REPO_NAME/$BRANCH"

# Cross-repo task location
CROSS_REPO_PATH="$CROSS_REPO_BASE/*/$REPO_NAME"

if [ -d "$WORKTREE_PATH" ]; then
  cd "$WORKTREE_PATH"
elif ls -d $CROSS_REPO_PATH 2>/dev/null | head -1; then
  cd "$(ls -d $CROSS_REPO_PATH 2>/dev/null | head -1)"
else
  # Fall back to wt-continue
  wt-continue "$REPO_NAME" "$BRANCH"
  cd "$WORKTREE_BASE/$REPO_NAME/$BRANCH"
fi
```

### 3. Safety Checks (MANDATORY — Do NOT Skip)

Before pulling, verify there is no uncommitted local work that could be lost:

```bash
# Check for uncommitted changes
if [ -n "$(git status --porcelain)" ]; then
  echo "❌ ABORT: Uncommitted changes detected in worktree."
  echo "Files with local changes:"
  git status --short
  echo ""
  echo "Resolve these manually before proceeding:"
  echo "  - Stash: git stash"
  echo "  - Commit: git add . && git commit"
  echo "  - Discard: git checkout -- ."
  exit 1
fi

# Check for unpushed commits
UNPUSHED=$(git log origin/"$BRANCH".."$BRANCH" --oneline 2>/dev/null)
if [ -n "$UNPUSHED" ]; then
  echo "⚠️  ABORT: Unpushed local commits detected:"
  echo "$UNPUSHED"
  echo ""
  echo "Push these first: git push origin $BRANCH"
  exit 1
fi
```

### 4. Sync with Remote

```bash
git fetch origin
git reset --hard "origin/$BRANCH"
```

Confirm: `git log --oneline -3` matches what's on GitHub.

### 5. Fetch All Unresolved Review Threads

From DrJKL/ticket-to-pr-pipeline, MIT.

More from DrJKL/ticket-to-pr-pipeline