core-finish

Files (1)

• SKILL.md

SKILL.md (first lines)

# 🏁 Core Task Finisher

## Overview
Close the loop seamlessly. Do not leave the branch messy or out of sync.

## Final Lifecycle Management

### 1. Verification Confirm
Did the `core-verify` pass entirely? If not, do not finish.

### 2. PR / Merge Prep
- Package the feature into clean, logical semantic commits (`feat`, `fix`, `chore`, `refactor`).
- Squash commits if necessary to maintain history hygiene.

### 3. Cleanup
- Remove any diagnostic code (like extraneous console.logs) and debug flags.
- Update internal `.md` plans/tickets marking them as complete.
- Leave branch, sync back to main development trunk.

---

## 📚 Examples

### Example 1: Feature Completion Workflow

**Scenario:** Completing a user authentication feature

```bash
# Step 1: Verify everything passes
npm test
npm run lint
npm run build

# Step 2: Clean up debug code
git diff  # Review changes
# Remove console.logs, debug flags, commented code

# Step 3: Commit with semantic message
git add .
git commit -m "feat: add user authentication with JWT

- Implement login/logout endpoints
- Add password hashing with bcrypt
- Create auth middleware
- Add tests for auth flow

Closes #123"

# Step 4: Update documentation
# Edit CHANGELOG.md, README.md if needed

# Step 5: Push and create PR
git push origin feature/user-auth
gh pr create --title "feat: User Authentication" --body "Implements JWT-based authentication system"

# Step 6: After merge, cleanup
git checkout main
git pull
git branch -d feature/user-auth
```

### Example 2: Bug Fix Completion

**Scenario:** Fixed a critical bug

```bash
# Step 1: Verify fix works
npm test -- --grep "payment processing"
npm run e2e

# Step 2: Clean commit
git add src/payment/processor.ts
git commit -m "fix: prevent duplicate payment processing

- Add idempotency key validation
- Implement transaction locking
- Add retry logic with exponential backoff

Fixes #456"

# Step 3: Hotfix deployment
git push origin hotfix/payment-duplicate
gh pr create --title "fix: Prevent duplicate payments" --label "hotfix"

# Step 4: After merge to main, backport to stable
git checkout stable
git cherry-pick <commit-hash>
git push origin stable
```

### Example 3: Refactoring Completion

**Scenario:** Code refactoring without feature changes

```bash
# Step 1: Verify no behavior changes
npm test
npm run build
# Compare bundle sizes

# Step 2: Squash commits for clean history
git rebase -i HEAD~5
# Mark commits as 'squash' except first

# Step 3: Clean commit message
git commit -m "refactor: simplify user service architecture

- Extract validation logic to separate module
- Replace class-based services with functions
- Improve type safety with stricter types
- No behavior changes, all tests pass"

# Step 4: Push
git push origin refactor/user-service --force-with-lease
```

---

## 🎯 Completion Checklist

From sigitpoerwo/repoworkspace_zahra, MIT.

More from sigitpoerwo/repoworkspace_zahra