code-review

Files (11)

• SKILL.md
• component.json · evals/
• contract-coverage.js · evals/
• contract-coverage.json · evals/
• grader.js · evals/
• index.js · evals/
• outcome.json · evals/
• package-closure.json · evals/
• review-artifact.js · evals/
• role.json · evals/
• trigger.json · evals/

SKILL.md (first lines)

# Code Review

Review one complete Ticket outcome without changing it.

## Required input

Require:

- originating requirements and durable references;
- an immutable implementation range with base and head revisions;
- the implementation handoff; and
- validation evidence.

Resolve the range to an immutable diff package before dispatch. Record every
input artifact reference in the run manifest. Stop as incomplete if an input is
missing, unreadable, mutable, or inconsistent with the range.

## Required dependencies

Invoke `review-worker`, `review-coordinator`, and `take-it-offline` by their exact
canonical Skill names. Stop before review execution with the first applicable
failure:

- `Missing internal dependency "review-worker"`
- `Missing internal dependency "review-coordinator"`
- `Missing internal dependency "take-it-offline"`

Use no copied fallback behavior and never select a test Adapter in production.

## Plan fresh lenses

Use separate fresh Review workers by default with these change-specific lenses:

1. **Domain** focuses on requirement meaning, user-visible behavior, domain
   invariants, and acceptance evidence.
2. **Engineering/Design** focuses on responsibilities, architecture, technology,
   compatibility, failure behavior, maintainability, and validation.

One combined worker is valid only when cited mechanical evidence shows that
behavior, contracts, state, dependencies, data, and failure handling are all
unchanged. Record the mechanical check, observed comparison, and references for
each dimension. A missing, false, or unsupported result requires separate Domain
and Engineering/Design workers.

Inspect change signals before dispatch. Add a fresh technology or specialist
Review lens when the changed language, framework, protocol, risk, or requested
scope requires it. Record the signals, capability decision, and assigned worker.
When required specialist capability is unavailable, record that gap as a Context
limit and run no general worker under the specialist label.

Give each worker the complete Ticket outcome and the same immutable diff
package. A worker receives the complete requirements, range, implementation
handoff, validation evidence, repository authority, and input artifact
references. Neither worker receives the other worker's output or conclusions.

Each worker must resolve Engineering Guidance independently. Do not inherit the
implementation handoff's concern dispositions. A missing planned lens or an
unsupported combined worker is structurally invalid and cannot become a complete
Review brief.

## Retain the review run

Keep generated review artifacts outside the repository. Retain:

- `run-manifest.json`, with run identity, complete Ticket outcome references,
  worker identities, lens provenance, immutable range, Ticket outcome
  fingerprint, consolidation evidence, specialist routing decisions, and an
  artifact index that binds each body by media type and SHA-256 digest;
- `diff-package.json`, the immutable diff package and its base and head;
- per-worker candidate streams containing complete finding records;
- one per-worker concern coverage artifact, separate from findings;
- `coordination.json`, containing coordination dispositions for every grouping,
  supersession, ordering, and retention decision;
- `completeness.json`, containing the completeness state and structural checks;
  and
- `review-brief.md`, the final Markdown brief and concise Review summary.

Use `take-it-offline` to preserve the fresh-context handoffs and final artifact
references. The owning Review role still defines and validates each review
artifact contract. Resolve every indexed body before completion. Validate its
schema or Markdown binding, content identity, run, worker, lens, immutable
range, Ticket outcome fingerprint, and digest. A missing, stale, swapped, or
inconsistent body makes the run incomplete.

## Coordinate structurally

Give the coordinator every planned worker output unchanged with retained references.
The coordinator validates structure, groups compatible duplicates, sorts
findings, unions coverage, preserves worker conclusions, and assembles the
Review brief. It performs no second review and makes no new finding.

Return an incomplete result when a required worker fails, a required artifact is
missing, a worker input identity differs, or any structural check fails. Retain
partial worker records and structured failure evidence. Record the exact
required completeness-check identities and their states, but do not create or
present `review-brief.md` for an incomplete run.

## Read-only boundary

Review may read repository, requirement, handoff, validation, and history
evidence. It may write only generated review artifacts to temporary artifact
storage. It does not:

- edit source, tests, configuration, or requirements;
- publish review comments;
- change issue, branch, pull-request, dependency, or release topology;
- decompose or dispatch remediation; or
- claim a reviewed-ticket result.

## Completion

Complete only when every required lens examined the same complete Ticket outcome,
each worker independently resolved all Engineering Guidance concerns, all worker
and coordinator structures validate, retained artifacts are inspectable, and the
concise Review summary links the immutable range and final Review brief.

From jhonDoe15/skills, MIT.

More from jhonDoe15/skills