ae-review

Files (5)

• SKILL.md
• browser.md · recipes/
• document.md · recipes/
• perspectives.md · recipes/
• xcode.md · recipes/

SKILL.md (first lines)

# Review

1. Resolve the target, intended change, and concrete review question. Reuse current review evidence for unchanged scope; review changes and unresolved risks. For a diff-only request with an empty diff, report no changes and stop; that does not establish product correctness.
2. Load at most one matching recipe:

- [`document.md`](recipes/document.md) for an Opportunity Brief, Concept Notebook, Implementation Plan, Delivery Map, or other specification;
- [`browser.md`](recipes/browser.md) for a real web flow;
- [`xcode.md`](recipes/xcode.md) for an Apple project;
- [`perspectives.md`](recipes/perspectives.md) for code, including the current diff.

The loaded recipe is the charge. `perspectives.md` may name several; every other recipe names one.

3. Select the smallest set of perspectives that answers the review question. On `perspectives.md`, use one perspective when it covers the question; add another only for a separate material risk. For an open-ended code review, use correctness plus any materially distinct perspective triggered by the target. A request for a thorough review takes every materially matching row. Name the trigger for each selection. On any other recipe, take its charge as the one perspective.
4. Inspect directly for a bounded single-perspective review unless independent review is requested or a separate reviewer would materially improve confidence. Delegate perspectives when independence or parallel inspection justifies the overhead. Each delegated packet contains the intended change, target paths, charge, and finding format below, with no inherited conversation. If required independence is unavailable, report that limitation; direct inspection is not an independent pass.
5. Complete each direct inspection and collect every delegated finding list or clean pass. A failed spawn or missing return is a failed perspective. Confirm each kept finding at the cited location. Keep findings that name a consequence and a correction. Collapse duplicates. Style survives only when it hides a defect.
6. Report findings ordered by severity, perspectives covered, whether review was direct or independent, and any failed or unavailable perspectives. A clean review states that plainly. Apply fixes when requested. Wording fixes run the `unslop` skill.

Each finding contains:

- severity;
- precise location (file and line, passage, or page) when applicable;
- the concrete consequence;
- the smallest useful correction.

Each perspective reports findings and leaves the tree unchanged.

From AndreaCatalucci/andrea-engineering, MIT.

More from AndreaCatalucci/andrea-engineering